Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design notes for function-type Default implementation discussion #71

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

Diggsey
Copy link
Contributor

@Diggsey Diggsey commented Nov 19, 2020

No description provided.

@joshtriplett
Copy link
Member

It would be helpful to see more of the use case, and in particular, what in practice the code calling add_one_thunk might look like.

@Diggsey
Copy link
Contributor Author

Diggsey commented Jun 3, 2021

I've updated based on the suggestions and added an example.

Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I tweaked the intro a bit, just reordering. Going to merge!

@nikomatsakis nikomatsakis merged commit aa1ff0b into rust-lang:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants