Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate jobserver fd more conservatively #6

Merged
merged 1 commit into from
Feb 24, 2018
Merged

Validate jobserver fd more conservatively #6

merged 1 commit into from
Feb 24, 2018

Conversation

ishitatsuyuki
Copy link
Contributor

Background: I'm planning to write a system-wide jobserver implementation. It uses sockets, not pipe, which will be rejected with the current validation.

Reference implementation in make: https://github.com/mirror/make/blob/48c8a116a914a325a0497721f5d8b58d5bba34d4/src/posixos.c#L124

Also in the docs:

If your tool determines that the --jobserver-auth option is available in MAKEFLAGS but that the file descriptors specified are closed,

So we don't need to force them to be a pipe.

@alexcrichton alexcrichton merged commit 921802c into rust-lang:master Feb 24, 2018
@alexcrichton
Copy link
Member

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants