Add reminder about review in welcome msg

rust-lang · Aug 5, 2022 · bbf7b20 · bbf7b20
1 parent 767cd4a
commit bbf7b20
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/highfive/newpr.py b/highfive/newpr.py
@@ -23,6 +23,8 @@
 raw_welcome = """Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from %s soon.
 
 Please see [the contribution instructions](%s) for more information.
+
+Tip: when your PR is ready for review, don't forget to fire up the command `@rustbot ready` to put your PR in the review queue of your assigned reviewer: this will help speed up the overall review process.
 """
 
 warning_summary = ':warning: **Warning** :warning:\n\n%s'

diff --git a/highfive/tests/test_integration_tests.py b/highfive/tests/test_integration_tests.py
@@ -103,7 +103,7 @@ def test_new_pr_non_contributor(self):
                 (
                     'POST', newpr.post_comment_url % ('rust-lang', 'rust', '7'),
                     {
-                        'body': "Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.\n\nPlease see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.\n"}
+                        'body': "Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.\n\nPlease see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.\n\nTip: when your PR is ready for review, don't forget to fire up the command `@rustbot ready` to put your PR in the review queue of your assigned reviewer: this will help speed up the overall review process.\n"}
                 ),
                 {'body': {}},
             ),
@@ -145,7 +145,7 @@ def test_new_pr_empty_body(self):
                 (
                     'POST', newpr.post_comment_url % ('rust-lang', 'rust', '7'),
                     {
-                        'body': "Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.\n\nPlease see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.\n"}
+                        'body': "Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.\n\nPlease see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.\n\nTip: when your PR is ready for review, don't forget to fire up the command `@rustbot ready` to put your PR in the review queue of your assigned reviewer: this will help speed up the overall review process.\n"}
                 ),
                 {'body': {}},
             ),

diff --git a/highfive/tests/test_newpr.py b/highfive/tests/test_newpr.py
@@ -113,6 +113,8 @@ def test_welcome_msg(self):
         base_msg = """Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from %s soon.
 
 Please see [the contribution instructions](%s) for more information.
+
+Tip: when your PR is ready for review, don't forget to fire up the command `@rustbot ready` to put your PR in the review queue of your assigned reviewer: this will help speed up the overall review process.
 """
 
         # No reviewer, no config contributing link.