Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test the MSRV with minimal dependency versions #572

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Oct 9, 2024

This includes a slight bump of rayon for use of ParallelIterator::copied, and pub(crate) on raw::Tag because older compilers complain about the pub(crate) methods that expose it.

@Amanieu
Copy link
Member

Amanieu commented Oct 12, 2024

I do think we should at least bump the MSRV to 1.65 since that's what we're actually testing in CI.

@cuviper
Copy link
Member Author

cuviper commented Oct 12, 2024

Yes, MSRV was already bumped to 1.65 in #565.

@cuviper
Copy link
Member Author

cuviper commented Oct 12, 2024

... but before this PR, we were not testing that MSRV in CI at all, just some later version that I assume was due to the latest dependency requirements.

@Amanieu
Copy link
Member

Amanieu commented Oct 14, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Oct 14, 2024

📌 Commit 066fd99 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 14, 2024

⌛ Testing commit 066fd99 with merge eea9804...

@bors
Copy link
Contributor

bors commented Oct 14, 2024

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing eea9804 to master...

@bors bors merged commit eea9804 into rust-lang:master Oct 14, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants