Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from actions-rs/toolchain@v1 to dtolnay/rust-toolchain@master and remove Cross.toml #467

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

JustForFun88
Copy link
Contributor

This PR replace the usage of actions-rs/toolchain@v1 with dtolnay/rust-toolchain as it is no longer maintained and uses the deprecated GitHub Actions API. The dtolnay/rust-toolchain provides similar functionality and also provides some additional features such as colored output.

Regarding the Cross.toml file, it is no longer needed after merging rust-lang/rust#115267.

@Amanieu
Copy link
Member

Amanieu commented Aug 31, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Aug 31, 2023

📌 Commit dcff369 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 31, 2023

⌛ Testing commit dcff369 with merge ec75914...

@bors
Copy link
Contributor

bors commented Aug 31, 2023

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing ec75914 to master...

@bors bors merged commit ec75914 into rust-lang:master Aug 31, 2023
@JustForFun88 JustForFun88 deleted the remove_cross_toml branch August 31, 2023 19:20
rkuris added a commit to ava-labs/firewood that referenced this pull request Sep 7, 2023
The former generates tons of warnings runs on deprecated subcomponents
and appears to be unmaintained.

References:
 * https://www.reddit.com/r/rust/comments/vyx4oj/actionsrs_organization_became_unmaintained/
 * actions-rs/toolchain#216
 * actions-rs/toolchain#220
 * rust-lang/hashbrown#467 (and many others
   doing this)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants