Reverse drain_filter behavior to match libstd
#187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit 6ea798c has been approved by |
bors
added a commit
that referenced
this pull request
Aug 11, 2020
Reverse `drain_filter` behavior to match libstd Fixes #186. This is the worst sort of silent breaking change, but we don't have much choice here.
|
Sorry, I forgot to update the docs to match the new behavior. Pushed a follow-up commit. |
|
@bors r+ |
|
📌 Commit 86abd6c has been approved by |
bors
added a commit
that referenced
this pull request
Aug 11, 2020
Reverse `drain_filter` behavior to match libstd Fixes #186. This is the worst sort of silent breaking change, but we don't have much choice here.
|
💔 Test failed - checks-travis |
mbrubeck
force-pushed
the
drain_filter_reverse
branch
from
86abd6c to
9253606
Compare
|
Updated the tests. |
|
@bors r+ |
|
📌 Commit 9253606 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 11, 2020
Reverse `drain_filter` behavior to match libstd Fixes #186. This is the worst sort of silent breaking change, but we don't have much choice here.
|
💔 Test failed - checks-travis |
mbrubeck
force-pushed
the
drain_filter_reverse
branch
from
9253606 to
7654023
Compare
|
Fixed the doc example to compile in Rust 1.32. Sorry for the churn! |
|
No problem! @bors r+ |
|
📌 Commit 7654023 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186. This is the worst sort of silent breaking change, but we don't have much choice here.