This repository was archived by the owner on May 23, 2024. It is now read-only.
Add test files for several btwn 22354 and 22919 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following tests were not added: 22354, 22387 22465, 22713, 22781, 22872, 22874. Where possible, the tests come from the shortest possible code samples to reproduce the ICE.
|
Thank you so much! |
steveklabnik
added a commit
that referenced
this pull request
Oct 25, 2015
Add test files for several btwn 22354 and 22919
|
It looks like the ones that got checked off on the tracking issue were the ones listed here as not added, and vice versa? |
|
Happy to! I definitely want to take a look at some of the trickier ones (e.x. rust-lang/rust#22354) that will take some more time to understand what's going on from the submitted code sample. @steveklabnik: this PR added tests for 22565, 22566, 22603, 22789, 22894, and 22919. Sorry for the confusion. |
|
Oh! I mis-read, darn. Thanks @wheals , I'll fix it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests in this range were not added: 22354, 22387,
22465, 22713, 22781, 22872, 22874. Where possible, the tests come
from the shortest possible code samples to reproduce the ICE.