Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Add ICE #67019 #227

Merged
merged 3 commits into from
Dec 6, 2019
Merged

Add ICE #67019 #227

merged 3 commits into from
Dec 6, 2019

Conversation

Julian-Wollersberger
Copy link
Contributor

It's a bit hacky because the ICE from rust-lang/rust#67019 needs compiler flags and I don't know of a way to provide that from within a .rs file.

ices/67019.sh Outdated Show resolved Hide resolved
@JohnTitor
Copy link
Member

Also, could you rebase this on top of rust-lang/master?

It's a bit hacky because the ICE from rust-lang/rust#67019 needs compiler flags and I don't know of a way to provide that from within a .rs file.
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating it

The reason for the permission denied error is because the file isn't marked executable in git. If that's because you're on windows where that's a pain you can use git update-index --chmod=+x ices/67019.sh

It was because `67019.sh` didn't have execute rights.
Glacier did run scripts as if you entered `./script.sh` in your prompt, but that requires execute rights on the script.
So I changed glacier to run `bash script.sh`, which only requires read rights.

Also, shouldn't glacier emit the `+nightly` flag to rustc?
@Julian-Wollersberger
Copy link
Contributor Author

Julian-Wollersberger commented Dec 6, 2019

Thanks, that error was confusing at first.
The fix I came up with was patching glacier to run bash script.sh, insted of ./script.sh, which only requires read rights.
Is that also ok? The only downside I that comes to my mind is that it hardcodes to bash scripts.

Edit: I did chmod +x anyway.

@Alexendoo
Copy link
Member

Yeah that's fine, a good idea actually since a plain ./script.sh doesn't work on some OSs (Windows)

For +nightly, it doesn't need to be explicitly passed because the repo contains a toolchain file: https://github.com/rust-lang/glacier/blob/master/rust-toolchain

Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Alexendoo Alexendoo merged commit 761a1db into rust-lang:master Dec 6, 2019
@Julian-Wollersberger
Copy link
Contributor Author

Thanks for reviewing ^^

@Julian-Wollersberger Julian-Wollersberger deleted the patch-1 branch January 15, 2020 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants