This repository was archived by the owner on May 23, 2024. It is now read-only.
Check exit code for ICE directly #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euclio
changed the title
|
Thank you! Let me know when this is ready to merge. |
|
For the time being I think this is blocked on rust-lang/rust#54992 |
Since rust-lang/rust#52197, ICEs will fail with exit status 101. Compilation successes and failures will return 0 and 1, respectively. Fixes rust-lang#143.
euclio
force-pushed
the
check-panic
branch
2 times, most recently
from
d97c9ea to
a2ef275
Compare
euclio
changed the title
|
@steveklabnik Ready for review. I deleted a fair number of tests which either no longer ICE'd or had tracking issues with the ICE label removed. |
|
Awesome, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rust-lang/rust#52197, ICEs will fail with exit status 101. Compilation successes and failures will return 0 and 1, respectively.
Fixes #143.