Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libgit2 submodule to recent main #708

Merged
merged 1 commit into from
May 18, 2021

Conversation

staktrace
Copy link
Contributor

This is specifically to pick up the fix
at libgit2/libgit2#5839

I'd appreciate a new git2-rs release as well! (not super urgent though)

@staktrace
Copy link
Contributor Author

Hm, looks like extprim-1.7.1 doesn't compile with the latest rustc nightly (2021-05-11). It compiled with an older nightly (I had 2020-12-14 prior to rustup update nightly).

@staktrace
Copy link
Contributor Author

Put up kennytm/extprim#21 to fix extprim but I don't know if the maintainer is active. It's been almost a year since the last commit to that repo.

@alexcrichton
Copy link
Member

Could CI be fixed by reducing the number of tests performed on nightly in that case?

@staktrace
Copy link
Contributor Author

The dependency chain for extprim is like so:

systest/Cargo.toml :: build-dependencies -> ctest -> syntex_syntax2 -> extprim.

Since the dependency is required for building systest, we could presumably skip those tests on the nightly component of the build matrix and things would then work again. I'll put up another PR for that. However that's a short-term solution because presumably this change in rustc will eventually roll out to beta and release as well. It might be worth also considering migrating ctest to use something other than syntex, which is now deprecated (even the github repo is archived).

@staktrace
Copy link
Contributor Author

#709 skips the systest for nightly rust.

This is specifically to pick up the fix
at libgit2/libgit2#5839
@staktrace
Copy link
Contributor Author

Rebased this PR on top of #709 so it's passing CI now.

@alexcrichton alexcrichton merged commit 0a64419 into rust-lang:master May 18, 2021
@staktrace
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants