Allow absolute paths for Repository::is_path_ignored. #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcrichton Sorry, I should have tested this more. As I noted in #549, I suspected this function might not need to be restricted. This will be needed for rust-lang/cargo#8095, so if you could push another release, I'd appreciate it. Also, I noticed with the last bump that you didn't push a commit to this repo with the |
|
No worries! I should get better about the release process anyway... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are passing absolute paths to
Repository::is_ignored_path. The changes from #549 cause these to be rejected. I don't think it necessarily needs to take a principled stance of "no absolute paths", and also since this breaks existing usage, I think it should just allow absolute paths.