Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support building USE_SSH=exec #1028

Open
extrawurst opened this issue Feb 23, 2024 · 1 comment · May be fixed by #1031
Open

support building USE_SSH=exec #1028

extrawurst opened this issue Feb 23, 2024 · 1 comment · May be fixed by #1031

Comments

@extrawurst
Copy link
Contributor

this will enable the use of OpenSSH instead of libssh hopefully fixing a bunch of problems

@bnjmnt4n
Copy link
Contributor

bnjmnt4n commented Mar 1, 2024

Hi, I'd like to work on this, with the goal of getting this into jj (martinvonz/jj#63).

bnjmnt4n added a commit to bnjmnt4n/git2-rs that referenced this issue Mar 1, 2024
This commit changes the original `ssh` feature into two new ones:
`ssh-libssh2` and `ssh-openssh`. By default, the `ssh-libssh2` feature
is enabled for backwards compatibility.

To use OpenSSH instead, the following listing in `Cargo.toml` can be
used:

    git2-rs = { version = "...", default-features = false, features = ["https", "ssh-openssh"] }

Note that libgit2/libgit2#6617 has not actually
been released in an official libgit2 version, so the prior commit pulled
in the latest commit from `main`.

Closes rust-lang#1028.
@bnjmnt4n bnjmnt4n linked a pull request Mar 1, 2024 that will close this issue
bnjmnt4n added a commit to bnjmnt4n/git2-rs that referenced this issue Mar 2, 2024
This commit changes the original `ssh` feature into two new ones:
`ssh-libssh2` and `ssh-openssh`. By default, the `ssh-libssh2` feature
is enabled for backwards compatibility.

To use OpenSSH instead, the following listing in `Cargo.toml` can be
used:

    git2-rs = { version = "...", default-features = false, features = ["https", "ssh-openssh"] }

Note that libgit2/libgit2#6617 has not actually
been released in an official libgit2 version, so the prior commit pulled
in the latest commit from `main`.

Closes rust-lang#1028.
bnjmnt4n added a commit to bnjmnt4n/git2-rs that referenced this issue Mar 2, 2024
This commit changes the original `ssh` feature into two new ones:
`ssh-libssh2` and `ssh-openssh`. By default, the `ssh-libssh2` feature
is enabled for backwards compatibility.

To use OpenSSH instead, the following listing in `Cargo.toml` can be
used:

    git2-rs = { version = "...", default-features = false, features = ["https", "ssh-openssh"] }

Note that libgit2/libgit2#6617 has not actually
been released in an official libgit2 version, so the prior commit pulled
in the latest commit from `main`.

Closes rust-lang#1028.
bnjmnt4n added a commit to bnjmnt4n/git2-rs that referenced this issue Mar 2, 2024
This commit changes the original `ssh` feature into two new ones:
`ssh-libssh2` and `ssh-openssh`. By default, the `ssh-libssh2` feature
is enabled for backwards compatibility.

To use OpenSSH instead, the following listing in `Cargo.toml` can be
used:

    git2-rs = { version = "...", default-features = false, features = ["https", "ssh-openssh"] }

This commit is stacked on top of rust-lang#1032, and should only be merged after
libgit2 v1.8.0 has been released.

Closes rust-lang#1028.
bnjmnt4n added a commit to bnjmnt4n/git2-rs that referenced this issue Mar 2, 2024
This commit changes the original `ssh` feature into two new ones:
`ssh-libssh2` and `ssh-openssh`. By default, the `ssh-libssh2` feature
is enabled for backwards compatibility.

To use OpenSSH instead, the following listing in `Cargo.toml` can be
used:

    git2-rs = { version = "...", default-features = false, features = ["https", "ssh-openssh"] }

This commit is stacked on top of rust-lang#1032, and should only be merged after
libgit2 v1.8.0 has been released.

Closes rust-lang#1028.
bnjmnt4n added a commit to bnjmnt4n/git2-rs that referenced this issue Mar 17, 2024
This commit changes the original `ssh` feature into two new ones:
`ssh-libssh2` and `ssh-openssh`. By default, the `ssh-libssh2` feature
is enabled for backwards compatibility.

To use OpenSSH instead, the following listing in `Cargo.toml` can be
used:

    git2-rs = { version = "...", default-features = false, features = ["https", "ssh-openssh"] }

This commit is stacked on top of rust-lang#1032, and should only be merged after
libgit2 v1.8.0 has been released.

Closes rust-lang#1028.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants