Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse rhs of select! arms using match-arm rules #2832

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Feb 28, 2024

Fixes #2824.

This is a breaking change because, for example, the following program would break.

use futures::{future, select};

fn main() {
    let _ = async {
        select! {
            () = future::ready(()) => {}()
        }
    };
}

Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 170a6ee into rust-lang:master Mar 3, 2024
24 checks passed
@taiki-e taiki-e added A-macro Area: macro related 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Mar 3, 2024
@taiki-e taiki-e mentioned this pull request Oct 5, 2024
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse error in select!/select_biased! macro
2 participants