Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FillBuf: don't poll a second time on EOF #2801

Merged
merged 1 commit into from
Nov 20, 2023
Merged

FillBuf: don't poll a second time on EOF #2801

merged 1 commit into from
Nov 20, 2023

Commits on Nov 18, 2023

  1. FillBuf: don't poll a second time on EOF 

    There is no hard guarantee that polling a second time will return
Poll::Ready, and this is particularly likely to break in the EOF case,
which is precisely where we don't need to do so at all.

Both tokio::io::BufReader and futures::io::BufReader always attempt to
read from the underlying reader when the buffer is empty, rather than
fusing EOF.
    @edef1c
    edef1c committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    f21483f View commit details
    Browse the repository at this point in the history