Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.28 #2735

Merged
merged 10 commits into from
Mar 30, 2023
Merged

Release 0.3.28 #2735

merged 10 commits into from
Mar 30, 2023

Conversation

taiki-e and others added 9 commits March 31, 2023 01:49
```
warning: `crate::task::panic_waker` is both a module and a function
  --> futures-test/src/task/mod.rs:26:23
   |
26 | //! - [`panic_waker`](crate::task::panic_waker) creates a waker that panics when
   |                       ^^^^^^^^^^^^^^^^^^^^^^^^ ambiguous link
   |
   = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default
help: to link to the module, prefix with `mod@`
   |
26 | //! - [`panic_waker`](mod@crate::task::panic_waker) creates a waker that panics when
   |                       ++++
help: to link to the function, add parentheses
   |
26 | //! - [`panic_waker`](crate::task::panic_waker()) creates a waker that panics when
   |                                               ++
```
* Don't ignore empty state polling

* Test case

* Start polling in a loop to ensure we don't wait for an outdated waker
```
error: unknown lint: `useless_anonymous_reexport`
 --> futures/tests/no-std/src/lib.rs:3:10
  |
3 | #![allow(useless_anonymous_reexport)]
  |          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `-D unknown-lints` implied by `-D warnings`

error: unused import: `futures_core::task::__internal::AtomicWaker as _`
 --> futures/tests/no-std/src/lib.rs:7:9
  |
7 | pub use futures_core::task::__internal::AtomicWaker as _;
  |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`

error: unused import: `futures_channel::oneshot as _`
  --> futures/tests/no-std/src/lib.rs:15:9
   |
15 | pub use futures_channel::oneshot as _;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: unused import: `futures::task::AtomicWaker as _`
  --> futures/tests/no-std/src/lib.rs:19:9
   |
19 | pub use futures::task::AtomicWaker as _;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: unused import: `futures::stream::FuturesOrdered as _`
  --> futures/tests/no-std/src/lib.rs:23:9
   |
23 | pub use futures::stream::FuturesOrdered as _;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: unused import: `futures_util::task::AtomicWaker as _`
  --> futures/tests/no-std/src/lib.rs:27:9
   |
27 | pub use futures_util::task::AtomicWaker as _;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: unused import: `futures_util::stream::FuturesOrdered as _`
  --> futures/tests/no-std/src/lib.rs:31:9
   |
31 | pub use futures_util::stream::FuturesOrdered as _;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
@taiki-e taiki-e added the futures-0.3 Issue related to the 0.3 versions of futures label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
futures-0.3 Issue related to the 0.3 versions of futures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants