Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve must_use comment on RemoteHandle #2408

Merged
merged 1 commit into from
May 6, 2021
Merged

improve must_use comment on RemoteHandle #2408

merged 1 commit into from
May 6, 2021

Conversation

ibraheemdev
Copy link
Member

resolves #2152

@ibraheemdev ibraheemdev requested a review from taiki-e as a code owner May 6, 2021 05:24
taiki-e
taiki-e approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@taiki-e taiki-e added the 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. label May 6, 2021
@taiki-e taiki-e merged commit f94dd92 into rust-lang:master May 6, 2021
@taiki-e taiki-e added A-future Area: futures::future docs labels May 6, 2021
@taiki-e taiki-e mentioned this pull request May 7, 2021
Merged
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
0.3-backport: completed A-future Area: futures::future docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve must_use comment on RemoteHandle
2 participants
@ibraheemdev @taiki-e