Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document flush behavior on error for send_all & forward #2404

Merged
merged 1 commit into from
May 1, 2021
Merged

Document flush behavior on error for send_all & forward #2404

merged 1 commit into from
May 1, 2021

Conversation

ktff
Copy link
Contributor

@ktff ktff commented Apr 30, 2021

Closes #2402

@ktff
Add doc
5502dd9 
Signed-off-by: ktf <krunotf@gmail.com>
@ktff ktff requested a review from taiki-e as a code owner April 30, 2021 16:37
taiki-e
taiki-e approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit cb0711e into rust-lang:master May 1, 2021
@ktff ktff deleted the ktff/doc_err_flush branch May 1, 2021 16:07
@taiki-e taiki-e added 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. A-sink Area: futures::sink labels May 7, 2021
taiki-e pushed a commit that referenced this pull request May 7, 2021
@ktff @taiki-e
Document flush behavior on error for send_all & forward (#2404)
0f0a1d0 
Signed-off-by: ktf <krunotf@gmail.com>
@taiki-e taiki-e mentioned this pull request May 7, 2021
Merged
taiki-e pushed a commit that referenced this pull request May 7, 2021
@ktff @taiki-e
Document flush behavior on error for send_all & forward (#2404)
a94c4b8 
Signed-off-by: ktf <krunotf@gmail.com>
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
0.3-backport: completed A-sink Area: futures::sink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SendAll doesn't flush on encountering Err from TryStream
2 participants
@ktff @taiki-e