Clean up private modules #2233
Clean up private modules #2233
Conversation
taiki-e
commented
Oct 15, 2020
taiki-e
commented
- Merge into one module per crate.
- Rename to __private. To prevent someone from accidentally using it...
- Shortened path to some private items.
- Use '=' requirement to futures-macro to avoid breakage due to private API changes. (This should be done in Support reexport for procedural macros #2124, but I missed that.)
futures-util/src/async_await/mod.rs
Outdated
|
|
||
| #[macro_use] | ||
| mod poll; | ||
| #[allow(unreachable_pub)] // https://github.com/rust-lang/rust/issues/57411 |
There was a problem hiding this comment.
I don't think this is that issue, that seems to specifically be a bad interaction between a fix-suggestion and having a deny-lint active (deleting the pub use in the example there results in a working program).
It seems since we don't make futures-util::async_await a pub mod and instead pub use async_await::*; these can all be pub(crate) and still work.
There was a problem hiding this comment.
Oh, no, I didn't realise re-exports could further constrain the visibility of the re-exported item, rather than just having a visibility applied to the re-export itself. I think this is more likely rust-lang/rust#64762
There was a problem hiding this comment.
Thanks, it certainly seems more likely to be rust-lang/rust#64762.
(Actually, the code mentioned in this comment looks almost the same as in this PR's case, except for the module itself warned.)
* Merge into one module per crate. * Rename to __private. * Shortened path to some private items. * Use '=' requirement to futures-macro to avoid breakage due to private API changes.
