Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncBufReadExt::fill_buf #2225

Merged
merged 3 commits into from
Oct 3, 2020
Merged

Add AsyncBufReadExt::fill_buf #2225

merged 3 commits into from
Oct 3, 2020

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Oct 2, 2020

For a long time I thought this was impossible to do safely because of lifetime issues, but (quite) a while ago @Darksonn showed me it was possible (at least for well behaved AsyncBufRead impls, for misbehaved ones we need polinius' improved lifetime inference to avoid polling it twice).

Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you re-export FillBuf on futures crate?

Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from #2225 (review).

@taiki-e taiki-e merged commit 8472da9 into rust-lang:master Oct 3, 2020
@taiki-e taiki-e mentioned this pull request Oct 5, 2020
@Nemo157 Nemo157 deleted the fill-buf branch October 14, 2020 10:38
@taiki-e taiki-e added the A-io Area: futures::io label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-io Area: futures::io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants