Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a is_connected_to to (Unbounded)Sender #2179

Merged
merged 3 commits into from
Sep 5, 2020
Merged

Added a is_connected_to to (Unbounded)Sender #2179

merged 3 commits into from
Sep 5, 2020

Conversation

LinkTed
Copy link
Contributor

@LinkTed LinkTed commented Jun 12, 2020

Hi,
I added a is_receiver function to the (Unbounded)Sender struct to check if a sender object belongs to this specific receiver object. The code is similar to same_receiver function.

@LinkTed
Copy link
Contributor Author

LinkTed commented Jun 12, 2020

Does someone know why Travis get this error?

error: failed to parse manifest at `/Users/travis/build/rust-lang/futures-rs/examples/functional/Cargo.toml`

I did not change anything in Cargo.toml.

@taiki-e
Copy link
Member

taiki-e commented Jun 12, 2020

That is cargo bug: rust-lang/cargo#8351

@LinkTed
Copy link
Contributor Author

LinkTed commented Jun 12, 2020

@taiki-e ohh thanks :)

@taiki-e
Copy link
Member

taiki-e commented Jun 12, 2020

Also, there is a PR that adds a similar method to oneshot (#2158), it seems to makes sense to use the same method name as that PR.

@LinkTed
Copy link
Contributor Author

LinkTed commented Jun 12, 2020

Done

@taiki-e taiki-e changed the title Added a is_receiver to (Unbounded)Sender Added a is_connected_to to (Unbounded)Sender Sep 5, 2020
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 575dcf8 into rust-lang:master Sep 5, 2020
@taiki-e taiki-e mentioned this pull request Oct 5, 2020
@taiki-e taiki-e added the A-channel Area: futures::channel label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-channel Area: futures::channel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants