Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "nightly" feature to "unstable" #1823

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Aug 23, 2019

Closes #1819

# `unstable` feature as an explicit opt-in to unstable API.
unstable = ["futures-core-preview/unstable"]
cfg-target-has-atomic = ["futures-core-preview/cfg-target-has-atomic"]
bench = []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"bench" feature is a feature for exposing BiLock, but it is not a stable public API and should be included here.

Related: #1679

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Maybe this should be renamed to bilock.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #1827

@cramertj cramertj merged commit ba91aa8 into rust-lang:master Aug 27, 2019
@taiki-e taiki-e deleted the unstable branch August 27, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "nightly" feature to "unstable"?
2 participants