Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unpin requirements from get_pin_mut #1820

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Aug 21, 2019

No description provided.

/// `Chain`.
pub fn get_pin_mut(self: Pin<&mut Self>) -> (Pin<&mut T>, Pin<&mut U>) {
unsafe {
let Self { first, second, .. } = self.get_unchecked_mut();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pin-project allows this to be handled in safe code.)

@taiki-e taiki-e changed the title Remove Unpin requirements from get_pin_mut and AsyncRead::take Remove Unpin requirements from get_pin_mut and AsyncReadExt::take Aug 21, 2019
@taiki-e taiki-e changed the title Remove Unpin requirements from get_pin_mut and AsyncReadExt::take Remove Unpin requirements from get_pin_mut Aug 21, 2019
@cramertj cramertj merged commit bff4218 into rust-lang:master Aug 27, 2019
@taiki-e taiki-e deleted the get-pin-mut branch August 27, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants