Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Sink::SinkError to Sink::Error #1708

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Rename Sink::SinkError to Sink::Error #1708

merged 1 commit into from
Jul 3, 2019

Conversation

seanmonstar
Copy link
Contributor

Closes #1707

@cramertj
Copy link
Member

cramertj commented Jul 3, 2019

r=me with travis passing.

@seanmonstar
Copy link
Contributor Author

Hrm, I'm guessing this failure is due to improvements in nightly?

---- join_size stdout ----
thread 'join_size' panicked at 'assertion failed: `(left == right)`
  left: `32`,
 right: `44`', futures/tests/async_await_macros.rs:178:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

@taiki-e
Copy link
Member

taiki-e commented Jul 3, 2019

@seanmonstar Yes, that is because the generator size has been improved. (rust-lang/rust#61922).

@cramertj
Copy link
Member

cramertj commented Jul 3, 2019

Yeah, I've got a PR updating those.

@cramertj
Copy link
Member

cramertj commented Jul 3, 2019

#1711

@cramertj
Copy link
Member

cramertj commented Jul 3, 2019

@seanmonstar Would you mind rebasing just so I can see a clean CI run on this before merging?

@carllerche carllerche mentioned this pull request Jul 3, 2019
Merged
@seanmonstar seanmonstar merged commit db4cad3 into rust-lang:master Jul 3, 2019
@seanmonstar seanmonstar deleted the sink-error branch July 3, 2019 19:29
@taiki-e taiki-e mentioned this pull request Jul 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Sink::SinkError to just Sink::Error
3 participants
@seanmonstar @cramertj @taiki-e