-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use #![warn(single_use_lifetimes)] #1680
Changes from all commits
31c0214
824488a
eb4cbfa
d98f015
812c0b6
4621fdb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,4 +22,4 @@ std = [] | |
proc-macro2 = "0.4" | ||
proc-macro-hack = "0.5.3" | ||
quote = "0.6" | ||
syn = { version = "0.15.22", features = ["full"] } | ||
syn = { version = "0.15.25", features = ["full"] } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why was this change required? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A warning occurred when building with minimal versions: https://travis-ci.com/rust-lang-nursery/futures-rs/jobs/209211855. (that warning was fixed in dtolnay/syn#563, and that change is included in 0.15.25 and later versions) (Context: After the first commit, I realized that CI did not catch(and reject) the warnings, so I added eb4cbfa and changed the warnings to be denied for all builds.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This enables
single_use_lifetimes
lint when runningcargo test
,cargo check --tests
etc. (FWIW, I often runcargo check --all-features --tests --all
locally before opening PR).