Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mpsc::Sender::poll_complete impl #1240

Merged
merged 3 commits into from
Sep 2, 2018
Merged

fix mpsc::Sender::poll_complete impl #1240

merged 3 commits into from
Sep 2, 2018

Conversation

carllerche
Copy link
Member

This fixes the "bounded senders are actually unbounded" problem. The
problem is discussed here: #984

The issue probably exists in the unsync mod. I am not sure about 0.3

@carllerche
fix mpsc::Sender::poll_complete impl
8a15912 
This fixes the "bounded senders are actually unbounded" problem. The
problem is discussed here: rust-lang#984
@carllerche
Fix test that relied on broken behavior
f659cb6
@carllerche carllerche mentioned this pull request Sep 1, 2018
Closed
2 tasks
@carllerche
Fix bench
4707a1a 
The bench is written assuming internal implementation details of the
channel which have changed after this fix. I removed the assertion which
isn't neecessary.
@MajorBreakfast MajorBreakfast mentioned this pull request Sep 2, 2018
Closed
@MajorBreakfast
Copy link
Contributor

@seanmonstar Could you review this one as well?

seanmonstar
seanmonstar approved these changes Sep 2, 2018
View reviewed changes
Copy link
Contributor

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another backport from tokio.

@MajorBreakfast MajorBreakfast merged commit 4b0e217 into rust-lang:0.1 Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

@cramertj cramertj Awaiting requested review from cramertj

@aturon aturon Awaiting requested review from aturon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carllerche @MajorBreakfast @seanmonstar