Skip to content

Commit

Permalink
Fix msrv: Run msrv checks with minimal versions
Browse files Browse the repository at this point in the history
Since it is possible to for dependencies to bump MSRV in patch release, msrv checking should use the minimal versions supported by flate2.

Users cares deeply about msrv can also pin them to the minimal versions to maintain their current msrv.

This would have also help discover bugs in #424
  • Loading branch information
NobodyXu committed Aug 23, 2024
1 parent 367ec74 commit 387b9c6
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Install Rust (rustup)
run: rustup update ${version} --no-self-update && rustup default ${version}
run: |
rustup toolchain install ${version} nightly --profile minimal --no-self-update
rustup default ${version}
cargo +nightly update -Zminimal-versions
shell: bash
- run: cargo build

0 comments on commit 387b9c6

Please sign in to comment.