Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask people to test the new uniform paths variant when transitioning #85

Merged
merged 2 commits into from
Aug 15, 2018

Conversation

joshtriplett
Copy link
Member

No description provided.

@Centril
Copy link
Contributor

Centril commented Aug 15, 2018

Seems travis is unhappy :(

@joshtriplett
Copy link
Member Author

@Centril Looks like it's going to be unhappy until nightly has the feature available, which is probably a good thing.

@Centril
Copy link
Contributor

Centril commented Aug 15, 2018

@joshtriplett Indeed; The changes themselves look mostly good but I'll do a quick review since it's no rush :)

Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits :)

@@ -43,6 +43,18 @@ require a Cargo.toml change to enable (described in the sections below). Also
note that during the time the preview is available, we may continue to add/enable
new features with this flag!

For Rust 2018 edition preview 2, we're also testing a [new module path
variant](rust-2018/path-clarity.html), "uniform paths", which we'd like to get
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"uniform paths" -> uniform_paths

your `lib.rs` or `main.rs`:

```rust
#![feature(rust_2018_preview,uniform_paths)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma between the features.

@@ -19,6 +19,10 @@ sections call out the differences between the two. We encourage testing of the
new "uniform paths" variant introduced in edition preview 2. The release of
Rust 2018 will stabilize one of these two variants and drop the other.

To test Rust 2018 with the new "uniform paths" variant, put
`#![feature(rust_2018_preview,uniform_paths)]` at the top of your `lib.rs` or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma :)

@@ -19,6 +19,10 @@ sections call out the differences between the two. We encourage testing of the
new "uniform paths" variant introduced in edition preview 2. The release of
Rust 2018 will stabilize one of these two variants and drop the other.

To test Rust 2018 with the new "uniform paths" variant, put
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"uniform paths" -> uniform_paths

@aturon
Copy link
Member

aturon commented Aug 15, 2018

Passes Travis now. Merging!

@aturon aturon merged commit 84a3764 into rust-lang:master Aug 15, 2018
@joshtriplett joshtriplett deleted the please-test-uniform-paths branch July 1, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants