Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement crates-admin binary #3011

Merged
merged 8 commits into from
Nov 13, 2020
Merged

Implement crates-admin binary #3011

merged 8 commits into from
Nov 13, 2020

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 9, 2020

This PR resolves #1504 by adding a new crates-admin binary, that combines a lot of the previously separate binaries as subcommands.

I would recommend to review commit-by-commit :)

r? @jtgeibel

@bors
Copy link
Contributor

bors commented Nov 11, 2020

☔ The latest upstream changes (presumably #2810) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@jtgeibel
Copy link
Member

The backfill-org-ids bin was removed in #2810 and can be dropped here as well. Also we should be updating bin_names in script/ci/prune-cache.sh as we add/remove binaries. (This is mostly a hack to improve CI cache performance on Travis, and may be less necessary on GH Actions and with fewer binaries, but lets maintain it for now.)

For deployment purposes, monitor and enqueue-job are called from the scheduler on Heroku and it will be best to keep those around for a single deployment cycle. For the rest of the binaries included in this migration, I think it is fine to drop them in this PR.

@Turbo87
Copy link
Member Author

Turbo87 commented Nov 11, 2020

@jtgeibel thanks for the review. I've removed monitor from the crates-admin tool, added it to the prune-cache.sh and removed the now obsolete binaries. :)

This description is for `monitor`, which was dropped from this PR.
@jtgeibel
Copy link
Member

I pushed a commit dropping the about attribute on populate (it was leftover from monitor).

I'm fine with migrating enqueue-job and monitor as well. We could even do so in a single PR. Just deploy first commits (up to where the bins are removed), update the scheduler, then deploy the merged commit.

Merging this PR and deploying to staging.

@bors r+

@bors
Copy link
Contributor

bors commented Nov 13, 2020

📌 Commit 9aa026c has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Nov 13, 2020

⌛ Testing commit 9aa026c with merge 01cdee4...

@bors
Copy link
Contributor

bors commented Nov 13, 2020

☀️ Test successful - checks-actions
Approved by: jtgeibel
Pushing 01cdee4 to master...

@bors bors merged commit 01cdee4 into rust-lang:master Nov 13, 2020
@Turbo87 Turbo87 deleted the crates-admin branch November 13, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile to a monolithic binary
4 participants