services/progress: Remove progress bar when running tests #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting for the progressbar to finish animating was slowing down the tests unnecessarily, so instead of waiting for it to finish animating we won't show it anymore at all.
locks
approved these changes
Sep 11, 2020
|
@bors r+ |
|
📌 Commit f47c0cf has been approved by |
bors
added a commit
that referenced
this pull request
Sep 11, 2020
services/progress: Remove progress bar when running tests Waiting for the progressbar to finish animating was slowing down the tests unnecessarily, so instead of waiting for it to finish animating we won't show it anymore at all. r? `@locks`
|
💔 Test failed - checks-travis |
|
@bors retry |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for the progressbar to finish animating was slowing down the tests unnecessarily, so instead of waiting for it to finish animating we won't show it anymore at all.
r? @locks