Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change most used to most directly depended upon #111

Closed
wants to merge 1 commit into from

Conversation

zzmp
Copy link

@zzmp zzmp commented Jan 8, 2015

Fixes #110

This is very verbose (it calls it Most Directly Depended Upon).
This calls the field Most Depended Upon, but is still verbose with the data field, calling the property most_directly_depended_upon.
Is this what we want?

@alexcrichton you mentioned in the issue to sort by dependencies-on.
Is this sufficient to count only direct dependencies?

@reem
Copy link
Contributor

reem commented Jan 8, 2015

I'd rather "Most Depended Upon"

@zzmp zzmp force-pushed the fix/used-to-depended-upon branch from d53fccf to 77ebefb Compare January 8, 2015 21:47
@zzmp
Copy link
Author

zzmp commented Jan 8, 2015

@reem Updated the HTML to call it "Most Depended Upon" but leave the data as most_directly_depended_upon for verbosity.

let most_downloaded = try!(tx.prepare("SELECT * FROM crates \
ORDER BY downloads DESC LIMIT 10"));
let most_directly_depended_upon = try!(tx.prepare("SELECT * FROM crates \
ORDER BY dependencies-on DESC LIMIT 10"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see this column defined in the "schema" (as in, it's not mentioned in the migration code), am I missing something?

(If it turns out this isn't defined, one may wish to look at reverse_dependencies which does essentially exactly the same thing.)

@alexcrichton
Copy link
Member

Yes unfortunately as @huonw mentioned this will require some deeper changes to implement. We do not currently track the number of immediate dependencies in the row for each crate. Additionally, the reverse dependencies page is currently implemented by joining many tables together, but for a home-page, often used query I don't think this is gonna cut it.

To implement this a counter will need to be maintained on the crates table of all immediate dependencies, both when dependencies are added as well as removed. That way we can actually just use a ORDER BY clause to sort everything correctly.

@brson
Copy link
Contributor

brson commented Oct 8, 2015

Closing because very old.

@brson brson closed this Oct 8, 2015
bors added a commit that referenced this pull request Dec 17, 2019
…itializers-2.1.1, r=Turbo87

Bump ember-load-initializers from 1.0.0 to 2.1.1

Bumps [ember-load-initializers](https://github.com/ember-cli/ember-load-initializers) from 1.0.0 to 2.1.1.
<details>
<summary>Release notes</summary>

*Sourced from [ember-load-initializers's releases](https://github.com/ember-cli/ember-load-initializers/releases).*

> ## Release 2.1.1
> #### 🐛 Bug Fix
> * [#205](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/205) Do not assume global variables are assigned to `self`. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### 🏠 Internal
> * [#159](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/159) Fixup eslint setup for typescript conversion. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### Committers: 1
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> ## Release 2.1.0
> #### 🚀 Enhancement
> * [#111](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/111) Add typescript support ([@&#8203;ro0gr](https://github.com/ro0gr))
>
> #### 📝 Documentation
> * [#125](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/125) Add more detailed explanation to README. ([@&#8203;abhilashlr](https://github.com/abhilashlr))
>
> #### 🏠 Internal
> * [#77](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/77) TravisCI: Remove deprecated `sudo: false` option ([@&#8203;Turbo87](https://github.com/Turbo87))
> * [#73](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/73) Remove unused dependencies ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### Committers: 4
> - Ruslan Hrabovyi ([@&#8203;ro0gr](https://github.com/ro0gr))
> - Tobias Bieniek ([@&#8203;Turbo87](https://github.com/Turbo87))
> - [[@&#8203;dependabot-preview](https://github.com/dependabot-preview)[bot]](https://github.com/apps/dependabot-preview)
> - abhilashlr ([@&#8203;abhilashlr](https://github.com/abhilashlr))
</details>
<details>
<summary>Changelog</summary>

*Sourced from [ember-load-initializers's changelog](https://github.com/ember-cli/ember-load-initializers/blob/master/CHANGELOG.md).*

> ## v2.1.1 (2019-11-02)
>
> #### 🐛 Bug Fix
> * [#205](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/205) Do not assume global variables are assigned to `self`. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### 🏠 Internal
> * [#159](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/159) Fixup eslint setup for typescript conversion. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### Committers: 1
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> ## v2.1.0 (2019-08-26)
>
> #### 🚀 Enhancement
> * [#111](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/111) Add typescript support ([@&#8203;ro0gr](https://github.com/ro0gr))
>
> #### 📝 Documentation
> * [#125](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/125) Add more detailed explanation to README. ([@&#8203;abhilashlr](https://github.com/abhilashlr))
>
> #### 🏠 Internal
> * [#77](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/77) TravisCI: Remove deprecated `sudo: false` option ([@&#8203;Turbo87](https://github.com/Turbo87))
> * [#73](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/73) Remove unused dependencies ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### Committers: 4
> - Ruslan Hrabovyi ([@&#8203;ro0gr](https://github.com/ro0gr))
> - Tobias Bieniek ([@&#8203;Turbo87](https://github.com/Turbo87))
> - [[@&#8203;dependabot-preview](https://github.com/dependabot-preview)[bot]](https://github.com/apps/dependabot-preview)
> - abhilashlr ([@&#8203;abhilashlr](https://github.com/abhilashlr))
>
> ## v2.0.0 (2018-10-29)
>
> #### 💥 Breaking Change
> * [#57](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/57) Update ember-cli-babel to 7. ([@&#8203;rwjblue](https://github.com/rwjblue))
> * [#56](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/56) Drop support for Node 4 ([@&#8203;loganrosen](https://github.com/loganrosen))
> * [#56](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/56) Drop support for ember-cli prior to 2.12 ([@&#8203;loganrosen](https://github.com/loganrosen))
>
> #### 🚀 Enhancement
> * [#56](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/56) Modernize to Ember CLI 3.5 blueprint ([@&#8203;loganrosen](https://github.com/loganrosen))
>
> #### 📝 Documentation
> * [#55](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/55) Fixing url typo ([@&#8203;thoov](https://github.com/thoov))
>
> #### Committers: 3
> - Logan Rosen ([@&#8203;loganrosen](https://github.com/loganrosen))
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
> - Travis Hoover ([@&#8203;thoov](https://github.com/thoov))
>
> ## [v1.1.0](https://github.com/ember-cli/ember-load-initializers/tree/v1.1.0) (2018-04-17)
> [Full Changelog](ember-cli/ember-load-initializers@v1.0.0...v1.1.0)
>
></tr></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`9851a98`](ember-cli/ember-load-initializers@9851a98) Release 2.1.1
- [`3c0e3ff`](ember-cli/ember-load-initializers@3c0e3ff) Do not assume global variables are assigned to `self`. ([#205](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/issues/205))
- [`8a0dff8`](ember-cli/ember-load-initializers@8a0dff8) Pin engine.io subdependency to avoid local test issues on Node 6
- [`b79fb98`](ember-cli/ember-load-initializers@b79fb98) Do not assume global variables are assigned to `self`.
- [`6563435`](ember-cli/ember-load-initializers@6563435) Build(deps-dev): Bump release-it from 12.4.0 to 12.4.1
- [`6882dcc`](ember-cli/ember-load-initializers@6882dcc) Build(deps-dev): Bump eslint-plugin-ember from 7.0.0 to 7.1.0
- [`2a386ce`](ember-cli/ember-load-initializers@2a386ce) Build(deps-dev): Bump eslint-plugin-prettier from 3.1.0 to 3.1.1
- [`2a6f903`](ember-cli/ember-load-initializers@2a6f903) Build(deps-dev): Bump @typescript-eslint/eslint-plugin
- [`788b695`](ember-cli/ember-load-initializers@788b695) Build(deps-dev): Bump release-it from 12.3.6 to 12.4.0
- [`05351a6`](ember-cli/ember-load-initializers@05351a6) Build(deps-dev): Bump @typescript-eslint/parser from 2.2.0 to 2.3.0
- Additional commits viewable in [compare view](ember-cli/ember-load-initializers@v1.0.0...v2.1.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-load-initializers&package-manager=npm_and_yarn&previous-version=1.0.0&new-version=2.1.1)](https://dependabot.com/compatibility-score.html?dependency-name=ember-load-initializers&package-manager=npm_and_yarn&previous-version=1.0.0&new-version=2.1.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
bors added a commit that referenced this pull request Dec 17, 2019
…itializers-2.1.1, r=Turbo87

Bump ember-load-initializers from 1.0.0 to 2.1.1

Bumps [ember-load-initializers](https://github.com/ember-cli/ember-load-initializers) from 1.0.0 to 2.1.1.
<details>
<summary>Release notes</summary>

*Sourced from [ember-load-initializers's releases](https://github.com/ember-cli/ember-load-initializers/releases).*

> ## Release 2.1.1
> #### 🐛 Bug Fix
> * [#205](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/205) Do not assume global variables are assigned to `self`. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### 🏠 Internal
> * [#159](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/159) Fixup eslint setup for typescript conversion. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### Committers: 1
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> ## Release 2.1.0
> #### 🚀 Enhancement
> * [#111](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/111) Add typescript support ([@&#8203;ro0gr](https://github.com/ro0gr))
>
> #### 📝 Documentation
> * [#125](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/125) Add more detailed explanation to README. ([@&#8203;abhilashlr](https://github.com/abhilashlr))
>
> #### 🏠 Internal
> * [#77](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/77) TravisCI: Remove deprecated `sudo: false` option ([@&#8203;Turbo87](https://github.com/Turbo87))
> * [#73](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/73) Remove unused dependencies ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### Committers: 4
> - Ruslan Hrabovyi ([@&#8203;ro0gr](https://github.com/ro0gr))
> - Tobias Bieniek ([@&#8203;Turbo87](https://github.com/Turbo87))
> - [[@&#8203;dependabot-preview](https://github.com/dependabot-preview)[bot]](https://github.com/apps/dependabot-preview)
> - abhilashlr ([@&#8203;abhilashlr](https://github.com/abhilashlr))
</details>
<details>
<summary>Changelog</summary>

*Sourced from [ember-load-initializers's changelog](https://github.com/ember-cli/ember-load-initializers/blob/master/CHANGELOG.md).*

> ## v2.1.1 (2019-11-02)
>
> #### 🐛 Bug Fix
> * [#205](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/205) Do not assume global variables are assigned to `self`. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### 🏠 Internal
> * [#159](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/159) Fixup eslint setup for typescript conversion. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### Committers: 1
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> ## v2.1.0 (2019-08-26)
>
> #### 🚀 Enhancement
> * [#111](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/111) Add typescript support ([@&#8203;ro0gr](https://github.com/ro0gr))
>
> #### 📝 Documentation
> * [#125](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/125) Add more detailed explanation to README. ([@&#8203;abhilashlr](https://github.com/abhilashlr))
>
> #### 🏠 Internal
> * [#77](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/77) TravisCI: Remove deprecated `sudo: false` option ([@&#8203;Turbo87](https://github.com/Turbo87))
> * [#73](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/73) Remove unused dependencies ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### Committers: 4
> - Ruslan Hrabovyi ([@&#8203;ro0gr](https://github.com/ro0gr))
> - Tobias Bieniek ([@&#8203;Turbo87](https://github.com/Turbo87))
> - [[@&#8203;dependabot-preview](https://github.com/dependabot-preview)[bot]](https://github.com/apps/dependabot-preview)
> - abhilashlr ([@&#8203;abhilashlr](https://github.com/abhilashlr))
>
> ## v2.0.0 (2018-10-29)
>
> #### 💥 Breaking Change
> * [#57](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/57) Update ember-cli-babel to 7. ([@&#8203;rwjblue](https://github.com/rwjblue))
> * [#56](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/56) Drop support for Node 4 ([@&#8203;loganrosen](https://github.com/loganrosen))
> * [#56](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/56) Drop support for ember-cli prior to 2.12 ([@&#8203;loganrosen](https://github.com/loganrosen))
>
> #### 🚀 Enhancement
> * [#56](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/56) Modernize to Ember CLI 3.5 blueprint ([@&#8203;loganrosen](https://github.com/loganrosen))
>
> #### 📝 Documentation
> * [#55](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/pull/55) Fixing url typo ([@&#8203;thoov](https://github.com/thoov))
>
> #### Committers: 3
> - Logan Rosen ([@&#8203;loganrosen](https://github.com/loganrosen))
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
> - Travis Hoover ([@&#8203;thoov](https://github.com/thoov))
>
> ## [v1.1.0](https://github.com/ember-cli/ember-load-initializers/tree/v1.1.0) (2018-04-17)
> [Full Changelog](ember-cli/ember-load-initializers@v1.0.0...v1.1.0)
>
></tr></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`9851a98`](ember-cli/ember-load-initializers@9851a98) Release 2.1.1
- [`3c0e3ff`](ember-cli/ember-load-initializers@3c0e3ff) Do not assume global variables are assigned to `self`. ([#205](https://github-redirect.dependabot.com/ember-cli/ember-load-initializers/issues/205))
- [`8a0dff8`](ember-cli/ember-load-initializers@8a0dff8) Pin engine.io subdependency to avoid local test issues on Node 6
- [`b79fb98`](ember-cli/ember-load-initializers@b79fb98) Do not assume global variables are assigned to `self`.
- [`6563435`](ember-cli/ember-load-initializers@6563435) Build(deps-dev): Bump release-it from 12.4.0 to 12.4.1
- [`6882dcc`](ember-cli/ember-load-initializers@6882dcc) Build(deps-dev): Bump eslint-plugin-ember from 7.0.0 to 7.1.0
- [`2a386ce`](ember-cli/ember-load-initializers@2a386ce) Build(deps-dev): Bump eslint-plugin-prettier from 3.1.0 to 3.1.1
- [`2a6f903`](ember-cli/ember-load-initializers@2a6f903) Build(deps-dev): Bump @typescript-eslint/eslint-plugin
- [`788b695`](ember-cli/ember-load-initializers@788b695) Build(deps-dev): Bump release-it from 12.3.6 to 12.4.0
- [`05351a6`](ember-cli/ember-load-initializers@05351a6) Build(deps-dev): Bump @typescript-eslint/parser from 2.2.0 to 2.3.0
- Additional commits viewable in [compare view](ember-cli/ember-load-initializers@v1.0.0...v2.1.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-load-initializers&package-manager=npm_and_yarn&previous-version=1.0.0&new-version=2.1.1)](https://dependabot.com/compatibility-score.html?dependency-name=ember-load-initializers&package-manager=npm_and_yarn&previous-version=1.0.0&new-version=2.1.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
Turbo87 pushed a commit to Turbo87/crates.io that referenced this pull request Jan 4, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the front page "most downloaded" list to "most directly depended upon"
5 participants