Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Predicate into Goal and Clause #531

Closed
1 of 3 tasks
oli-obk opened this issue Jul 20, 2022 · 3 comments
Closed
1 of 3 tasks

Split Predicate into Goal and Clause #531

oli-obk opened this issue Jul 20, 2022 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Jul 20, 2022

Proposal

Chalk and a-mir-formality have the concept of Goal and Clause that wrap certain subsets of what currently is Predicate to differentiate between things that need to be proven (e.g. when invoking x + y, a goal typeof(x): Add<typeof(y)> is introduced) and things that we know must hold (where clauses and implied bounds, essentially the ParamEnv).

Doing this will remove differences between rustc trait solving and chalk, and paves the way for properly checking higher kinded lifetime bounds (it would be possible without this, but it's annoying and not making the code more readable).

Mentors or Reviewers

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@oli-obk oli-obk added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Jul 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2022

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jul 20, 2022
@lcnr
Copy link
Contributor

lcnr commented Jul 20, 2022

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jul 20, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 21, 2022
@apiraino
Copy link
Contributor

apiraino commented Aug 3, 2022

@rustbot label -final-comment-period +major-change-accepted

@apiraino apiraino closed this as completed Aug 3, 2022
@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Aug 3, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Aug 25, 2022
@oli-obk oli-obk mentioned this issue Nov 16, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#104483 - oli-obk:santa-clauses-make-goals, …
ff424d0 
…r=compiler-errors

Convert predicates into Predicate in the Obligation constructor

instead of having almost all callers do that.

This reduces a bit of boilerplate, and also paves the way for my work towards rust-lang/compiler-team#531 (as it makes it easier to accept both goals and clauses where right now it only accepts predicates).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#104483 - oli-obk:santa-clauses-make-goals, …
8c3bad2 
…r=compiler-errors

Convert predicates into Predicate in the Obligation constructor

instead of having almost all callers do that.

This reduces a bit of boilerplate, and also paves the way for my work towards rust-lang/compiler-team#531 (as it makes it easier to accept both goals and clauses where right now it only accepts predicates).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#104483 - oli-obk:santa-clauses-make-goals, …
9eaeed5 
…r=compiler-errors

Convert predicates into Predicate in the Obligation constructor

instead of having almost all callers do that.

This reduces a bit of boilerplate, and also paves the way for my work towards rust-lang/compiler-team#531 (as it makes it easier to accept both goals and clauses where right now it only accepts predicates).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#104483 - oli-obk:santa-clauses-make-goals, …
ed97f24 
…r=compiler-errors

Convert predicates into Predicate in the Obligation constructor

instead of having almost all callers do that.

This reduces a bit of boilerplate, and also paves the way for my work towards rust-lang/compiler-team#531 (as it makes it easier to accept both goals and clauses where right now it only accepts predicates).
flip1995 pushed a commit to flip1995/rust-clippy that referenced this issue Nov 19, 2022
@matthiaskrgr
Rollup merge of #104483 - oli-obk:santa-clauses-make-goals, r=compile…
f7535e7 
…r-errors

Convert predicates into Predicate in the Obligation constructor

instead of having almost all callers do that.

This reduces a bit of boilerplate, and also paves the way for my work towards rust-lang/compiler-team#531 (as it makes it easier to accept both goals and clauses where right now it only accepts predicates).
@spastorino spastorino mentioned this issue Nov 24, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 25, 2022
@bors
Auto merge of rust-lang#104846 - spastorino:santa-clauses-make-goals-…
051cab2 
…early-christmas-🎄, r=oli-obk

Branch Clause from Predicate

r? `@oli-obk`

This is part of what's proposed in rust-lang/compiler-team#531
flip1995 pushed a commit to flip1995/rust-clippy that referenced this issue Dec 1, 2022
@bors
Auto merge of #104846 - spastorino:santa-clauses-make-goals-early-chr…
8b2f7e3 
…istmas-🎄, r=oli-obk

Branch Clause from Predicate

r? `@oli-obk`

This is part of what's proposed in rust-lang/compiler-team#531
@oli-obk oli-obk mentioned this issue Jan 24, 2023
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oli-obk @apiraino @lcnr @rustbot