Add cygwin support #774
Merged
Add cygwin support #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Berrysoft
force-pushed
the
dev/cygwin-main
branch
from
04a2cd9 to
aa73463
Compare
|
Do I have to add cfg-check for this new target? |
3 tasks
|
The failing job has a pinned rustc version due to a bug in the latest LLVM upgrade, but that should be resolved in a soonish nightly. Just to confirm, cygwin doesn't support weak linking? |
|
No, it doesn't. |
tgross35
approved these changes
Mar 1, 2025
There was a problem hiding this comment.
lgtm but blocked on rust-lang/rust#137661 and the current builtins sync
tgross35
reviewed
Mar 5, 2025
Comment on lines
+45
to
+46
| // Windows and Cygwin already has builtins to do this. | ||
| #![cfg(not(any(windows, target_os = "cygwin")))] |
There was a problem hiding this comment.
Nit if you have time, s/has/have/
|
CI should be fixed with #782. I still have to hold off merging until rust-lang/rust#137634 goes through. |
tgross35
force-pushed
the
dev/cygwin-main
branch
from
aa73463 to
f652d2a
Compare
Co-authored-by: Ookiineko <chiisaineko@protonmail.com>
tgross35
force-pushed
the
dev/cygwin-main
branch
from
f652d2a to
27ee9ca
Compare
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Mar 5, 2025
This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 5, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Mar 5, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Mar 5, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
Mar 6, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Mar 6, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2025
Rollup merge of rust-lang#138038 - tgross35:update-builtins, r=tgross35 Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Mar 7, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Mar 10, 2025
Update `compiler-builtins` to 0.1.151 This enables `f16` builtins for loongarch [1] and adds support for Cygwin [2]. [1]: rust-lang/compiler-builtins#770 [2]: rust-lang/compiler-builtins#774 try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes ported from Ookiineko.