Add #[linkage = "weak"] attribute to all mem instrinics.
#411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weak linkage isn't properly supported on some targets (Windows, maybe apple too) and should be disabled on those. |
MabezDev
force-pushed
the
mem-intrinsics-weak-linkage
branch
from
b8c5f64 to
ba9e00c
Compare
|
I grepped the grep -rn "allows_weak_linkage"
windows_gnu_base.rs:80: allows_weak_linkage: false,
uefi_msvc_base.rs:44: allows_weak_linkage: false,The changes I have just pushed should cover those cases. |
|
Current CI error seems unrelated? Failing to pull a docker registry it seems. |
MabezDev
added a commit
to esp-rs/esp32-hal
that referenced
this pull request
Aug 11, 2021
* Bump xtensa-lx crates * Bump esp32 crate * Update to fix any breaking changes * use `build-std` by default - now that rust-lang/compiler-builtins#411 is merged
MabezDev
added a commit
to esp-rs/esp32-hal
that referenced
this pull request
Aug 12, 2021
* Ecosystem bump * Bump xtensa-lx crates * Bump esp32 crate * Update to fix any breaking changes * use `build-std` by default - now that rust-lang/compiler-builtins#411 is merged * v0.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #379, in particular this comment #379 (comment).
The rational for such a change is to provide a simple way to override the builtin memcpy routines, in particular
no_stdtargets because thememfeature ofcompiler-builtinsis always enabled for those targets and cannot be disabled.