Skip to content

Commit

Permalink
Disable quickcheck tests on mips
Browse files Browse the repository at this point in the history
Two reasons:
    * the C versions __divti3 and __modti3 are apparently broken,
      at least when used in quickcheck. They change their own arguments.
    * compiler_rt's support for mips is disabled already on clang.
      Its desireable to support working "cargo test" on that compiler
      as well, and not greet the tester with linker errors.
  • Loading branch information
est31 committed Feb 4, 2017
1 parent f8a4e3f commit 7832af9
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 6 deletions.
5 changes: 4 additions & 1 deletion compiler-rt/compiler-rt-cdylib/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@ declare!(___adddf3, __adddf3);
declare!(___powisf2, __powisf2);
declare!(___powidf2, __powidf2);

#[cfg(all(not(windows), target_pointer_width="64"))]
#[cfg(all(not(windows),
not(target_arch = "mips64"),
not(target_arch = "mips64el"),
target_pointer_width="64"))]
pub mod int_128 {
extern {
fn __lshrti3();
Expand Down
5 changes: 4 additions & 1 deletion src/int/mul.rs
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,10 @@ mod tests {
}

#[cfg(test)]
#[cfg(all(not(windows), target_pointer_width="64"))]
#[cfg(all(not(windows),
not(target_arch = "mips64"),
not(target_arch = "mips64el"),
target_pointer_width="64"))]
mod tests_i128 {
use qc::I128;

Expand Down
7 changes: 5 additions & 2 deletions src/int/sdiv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,14 @@ mod tests {
}

#[cfg(test)]
#[cfg(all(not(windows), target_pointer_width="64"))]
#[cfg(all(not(windows),
not(target_arch = "mips64"),
not(target_arch = "mips64el"),
target_pointer_width="64"))]
mod tests_i128 {
use qc::U128;

check! {

fn __divti3(f: extern fn(i128, i128) -> i128, n: U128, d: U128) -> Option<i128> {
let (n, d) = (n.0 as i128, d.0 as i128);
if d == 0 {
Expand Down
5 changes: 4 additions & 1 deletion src/int/shift.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,10 @@ mod tests {
}

#[cfg(test)]
#[cfg(all(not(windows), target_pointer_width="64"))]
#[cfg(all(not(windows),
not(target_arch = "mips64"),
not(target_arch = "mips64el"),
target_pointer_width="64"))]
mod tests_i128 {
use qc::{I128, U128};

Expand Down
5 changes: 4 additions & 1 deletion src/int/udiv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,10 @@ mod tests {
}

#[cfg(test)]
#[cfg(all(not(windows), target_pointer_width="64"))]
#[cfg(all(not(windows),
not(target_arch = "mips64"),
not(target_arch = "mips64el"),
target_pointer_width="64"))]
mod tests_i128 {
use qc::U128;

Expand Down

0 comments on commit 7832af9

Please sign in to comment.