Fix projection substitution order considering GATs #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Mar 19, 2023
internal: Bump chalk This release fixes a problem around GATs (rust-lang/chalk#790). While a regression test is added in chalk's own test suite, I also added one in ours so that we can catch regressions when we move away from chalk. Fixes #14164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
AliasEqgoal contains another alias as its self type, we generate the following clause:<<X as Y>::A as Z>::B == U :- <T as Z>::B == U, <X as Y>::A == T, withTbeing a new variable. We've been building<T as Z>::Bby swapping the first argument in the original projection's substitution withT, but it's not the self type when the associated typeBhas generic parameters, leading to wrong subgoals.The added test would yield "No possible solution" in current master.
Also removes
ignoreattribute on a doctest that was added in #778 as GATs hit stable.Spotted in rust-lang/rust-analyzer#14164.