More clause fixes #728
Merged
More clause fixes #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since const generics are primarily used by arrays, this avoids an unusual disparity between Chalk and Rust.
There's no way to enumerate all types these can apply to. Flounder if we have to prove that one of these traits applies to an inference variable.
Check that `T: 'a` for `&'a T` and `&'a mut T`, check that `T: Sized` in `[T]`, `[T; N]` and `(..., T, ...)`.
matthewjasper
force-pushed
the
wf-clauses
branch
from
6ef1a86 to
f8ba227
Compare
|
Overall this looks quite good to me. I was trying to look through history a bit here to see why the WF clauses haven't always been this way. Anyways, I want to review this once more when I'm not on mobile before I merge, but this is quite appreciated! |
|
@bors r+ |
|
📌 Commit f8ba227 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WellFormedusizein chalk-integration