Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chalk-recursive): allow chalk-solve's default-features to be disabled #703

Merged
merged 1 commit into from
May 10, 2021

Conversation

memoryruins
Copy link
Contributor

Without this change, one of the issues mentioned in #686 continue to persist after #687 because chalk-solve's features were enabled unconditionally when depending on chalk-recursive.

Now chalk-solve's tracing-full feature is enabled when chalk-recursive's tracing-full feature is enabled (which it continues to be by default; it may be worth considering disabling these by default in the future, as #686 suggested, to minimize this sort of issue).

@memoryruins memoryruins changed the title fix(chalk-recursive): allow chalk-solve's default-features to be disaabled fix(chalk-recursive): allow chalk-solve's default-features to be disabled May 8, 2021
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 10, 2021

📌 Commit 3b20ee5 has been approved by jackh726

@bors
Copy link
Contributor

bors commented May 10, 2021

⌛ Testing commit 3b20ee5 with merge 3d0dacc...

@bors
Copy link
Contributor

bors commented May 10, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 3d0dacc to master...

@bors bors merged commit 3d0dacc into rust-lang:master May 10, 2021
@memoryruins memoryruins deleted the conditional branch May 10, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants