Fix some book typos #695
Merged
Fix some book typos #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detrumi
suggested changes
Mar 26, 2021
| @@ -166,7 +166,7 @@ The conclusion from all of this is that it is perfectly safe to rule out impls t | |||
|
|
|||
| **Downstream Crates:** Downstream crates come into play because all traits in upstream crates and in the current crate can potentially be implemented by downstream crates using the forms allowed by the orphan rules. In essence, we always need to assume that downstream crates will implement traits in all ways that compile. | |||
|
|
|||
| ## Discussion: Modelling the Overlap Check | |||
| ## Discussion: Modeling the Overlap Check | |||
There was a problem hiding this comment.
Looks like one or 2 L's are both fine, depending on whether it's American English or not. But I think we default to American English in most places, so 👍
There was a problem hiding this comment.
Oh I had no idea that it was correct in non American English. I can leave it as it was.
book/src/types/rust_types.md
Outdated
| @@ -142,7 +142,7 @@ them in the [aliases chapter](./rust_types/alias.md). | |||
| The `BoundVar` variant represents some variable that is bound in | |||
| an outer term. For example, given a term like `forall<X> { | |||
| Implemented(X: Trait) }`, the `X` is bound. Bound variables in chalk | |||
| (like rustc) use de bruijin indices (See below). | |||
| (like rustc) use de bruijn indices (See below). | |||
There was a problem hiding this comment.
We should change this to "De Bruijn indices"
There was a problem hiding this comment.
Changed all occurrences to De Bruijn
detrumi
approved these changes
Mar 26, 2021
|
@bors r+ |
|
📌 Commit 574ea9d has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these changes are correct but check it out just in case, there's one or two that I'm not 100% sure.