Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mdbook #672

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Update mdbook #672

merged 1 commit into from
Jan 4, 2021

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jan 4, 2021

Changelog to 0.4.5: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-045

I removed mdbook-toc instead of updating it, because it does not appear to be used anywhere.

mdbook-mermaid is no longer publishing pre-compiled binaries, so it needs to be built locally.

Newer versions of mdbook require the optional flag for missing backends, so I added it for mdbook-linkcheck. This means that if mdbook-linkcheck is not installed, it will just display a warning instead of failing.

I could add some caching for mdbook-mermaid if you want. Caching can be fussy, so I'm not sure if you actually want it, but I think it would look something like this (untested):

      - uses: actions/cache@v2
        with:
          path: |
            ~/.cargo/registry
            ~/.cargo/bin/mdbook-mermaid
            ~/.cargo/.crates.toml
            ~/.cargo/.crates2.json
          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock', '.github/workflows/*.yml') }}
          restore-keys: ${{ runner.os }}-cargo-

@jackh726
Copy link
Member

jackh726 commented Jan 4, 2021

Given that this is a security-related update, I'm going to accept this.

I'm not sure if we want caching. It could be useful, but I guess we'll see how CI times do. I'll also note down to bring this up in a wg-traits meeting.

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 4, 2021

📌 Commit 2a79522 has been approved by jackh726

@bors
Copy link
Contributor

bors commented Jan 4, 2021

⌛ Testing commit 2a79522 with merge caa6910...

@bors
Copy link
Contributor

bors commented Jan 4, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing caa6910 to master...

@bors bors merged commit caa6910 into rust-lang:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants