Don't panic on unimplemented types for auto traits #622
Conversation
jackh726
changed the title
| @@ -164,6 +164,10 @@ pub fn push_auto_trait_impls<I: Interner>( | |||
| push_auto_trait_impls_generator_witness(builder, auto_trait_id, generator_id); | |||
| } | |||
|
|
|||
| // Unimplemented | |||
| TypeName::OpaqueType(_) => {} | |||
There was a problem hiding this comment.
Would it be cleaner to replace the unimplemented! calls in the constituent_types fn above with a FIXME comment and a reference to some issue? I'm not familiar with the chalk style guide, but I feel like leaving in the unimplemented calls could lead to them accidentally being triggered in the future.
Something like // FIXME (issue#12345) implement these
There was a problem hiding this comment.
The problem is that in order to do that, we would have to change the function signature to an Option<...>. If this was a long term solution, yeah that might be cleaner. But for now, this is fine to reduce churn.
|
@bors r=nikomatsakis Discussed on zulip during meeting |
|
📌 Commit 9663ae0 has been approved by |
|
☀️ Test successful - checks-actions |
Closes #621