Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend well-known traits by Unpin #603

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Conversation

memoryleak47
Copy link
Contributor

I read the RFC and didn't find any special rules concerning Unpin, so this one is rather straight-forward. Correct me if I missed something!
cc #363

Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right. I think Unpin needs to be implemented for all the built in types. Std has impls for all scalars, ref, raws; but we need builtin impls for function pointers, function defs, arrays, str, closures, slices(?).

@jackh726
Copy link
Member

jackh726 commented Sep 7, 2020

Also, please update the well known traits table in the book.

@memoryleak47 memoryleak47 changed the title Extend well-known traits by Unpin [WIP] Extend well-known traits by Unpin Sep 7, 2020
@memoryleak47
Copy link
Contributor Author

I thought this was a consequence of defining it as an auto trait. I'll look into it.

@bors
Copy link
Contributor

bors commented Sep 7, 2020

☔ The latest upstream changes (presumably #602) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pretty straightfoward until we get generators and auto traits for builtin types.

@jackh726
Copy link
Member

jackh726 commented Sep 9, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Sep 9, 2020

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove [WIP] from this PR's title when it is ready for review.

@jackh726 jackh726 changed the title [WIP] Extend well-known traits by Unpin Extend well-known traits by Unpin Sep 9, 2020
@jackh726
Copy link
Member

jackh726 commented Sep 9, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Sep 9, 2020

📌 Commit c25997c has been approved by jackh726

@bors
Copy link
Contributor

bors commented Sep 9, 2020

⌛ Testing commit c25997c with merge 01b4bff...

@bors
Copy link
Contributor

bors commented Sep 9, 2020

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 01b4bff to master...

@bors bors merged commit 01b4bff into rust-lang:master Sep 9, 2020
@memoryleak47 memoryleak47 deleted the unpin branch September 9, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants