-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend well-known traits by Unpin #603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is right. I think Unpin
needs to be implemented for all the built in types. Std has impls for all scalars, ref, raws; but we need builtin impls for function pointers, function defs, arrays, str
, closures, slices(?).
Also, please update the well known traits table in the book. |
I thought this was a consequence of defining it as an auto trait. I'll look into it. |
☔ The latest upstream changes (presumably #602) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Pretty straightfoward until we get generators and auto traits for builtin types.
@bors r+ |
📋 Looks like this PR is still in progress, ignoring approval. Hint: Remove [WIP] from this PR's title when it is ready for review. |
@bors r+ |
📌 Commit c25997c has been approved by |
☀️ Test successful - checks-actions |
I read the RFC and didn't find any special rules concerning Unpin, so this one is rather straight-forward. Correct me if I missed something!
cc #363