Properly unify consts with vars #598
Conversation
There was a problem hiding this comment.
One small comment. These seem mostly copied from the Ty cases, and that makes sense to me. But I would really like a second look from @nikomatsakis or maybe @Areredify in terms of whether this is actually correct (and why it was left out of the original PR i.e. was it just oversight or something else)
chalk-solve/src/infer/unify.rs
Outdated
| self.table | ||
| .unify | ||
| .unify_var_value(var, InferenceValue::from_const(interner, c.clone())) | ||
| .unify_var_value(var, InferenceValue::from_const(interner, c1.clone())) |
There was a problem hiding this comment.
Does this actually need to be a clone? The line below uses c (though should probably be c1), but we could print that before this.
|
Oh yeah, it was most certainly an oversight. I actually saw it when working on universe canonicalization but forgot to push it separately |
|
@bors r+ book links are broken with latest rust directory moving around business, but we can leave that for another PR |
|
📌 Commit 584ddfe has been approved by |
|
☀️ Test successful - checks-actions |
Before, we incorrectly unified consts with vars unconditionally.
Fixes #597.