Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle well known traits for more types #591

Merged
merged 7 commits into from
Aug 4, 2020

Conversation

nathanwhit
Copy link
Member

Adds clauses for well known traits (mostly Sized, Copy) for more types, including inference vars and bound vars. Also reorganizes tests for well known traits and adds some missing tests.

Fixes #590.
Fixes #533.

chalk-solve/src/clauses/builtin_traits/copy.rs Outdated Show resolved Hide resolved
chalk-solve/src/clauses/builtin_traits/copy.rs Outdated Show resolved Hide resolved
chalk-solve/src/clauses/builtin_traits/sized.rs Outdated Show resolved Hide resolved
tests/test/functions.rs Outdated Show resolved Hide resolved
tests/test/refs.rs Outdated Show resolved Hide resolved
tests/test/refs.rs Outdated Show resolved Hide resolved
tests/test/scalars.rs Outdated Show resolved Hide resolved
@nathanwhit nathanwhit force-pushed the well-known-traits-fix branch from db53993 to 974762b Compare August 4, 2020 19:19
@jackh726
Copy link
Member

jackh726 commented Aug 4, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Aug 4, 2020

📌 Commit 974762b has been approved by jackh726

@bors
Copy link
Contributor

bors commented Aug 4, 2020

⌛ Testing commit 974762b with merge eed228c...

@jackh726
Copy link
Member

jackh726 commented Aug 4, 2020

I'm also going to do a release after this gets merged to make sure things are good with rustc.

@bors
Copy link
Contributor

bors commented Aug 4, 2020

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing eed228c to master...

@bors bors merged commit eed228c into rust-lang:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression for well known trait impls for builtin types Reorganize(/cleanup) tests
3 participants