Check well-formedness of opaque type declarations #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackh726
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
This looks right to me. I want @nikomatsakis eyes on it though. I guess the assumption is that wherever the wf is done, we have to be able to know the hidden type. But I guess that's the concern of the caller?
|
@nathanwhit if you rebase, I'm happy to merge |
nathanwhit
force-pushed
the
opaque-wf
branch
from
a48491b to
22963e2
Compare
|
@bors r=nikomatsakis |
|
📌 Commit 22963e2 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.