Allow printing lifetime placeholders #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jul 4, 2020
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
|
I think it makes sense to not rely on these kinds of invariants anyway in the printer -- its whole purpose is debugging, so it should be somewhat resilient to wrong inputs. (For the same reason, I think it'd be a good idea to replace the |
detrumi
force-pushed
the
chalk-writer-integration-workarounds
branch
from
a54d73c to
85d0d72
Compare
jackh726
approved these changes
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-analyzer currently doesn't implement lifetimes, but inserts placeholders instead: https://github.com/rust-analyzer/rust-analyzer/blob/9f754e0518e7f2860891079a117a3e4bc6f4a8fd/crates/ra_hir_ty/src/traits/chalk/mapping.rs#L141
To avoid crashing when displaying programs coming from rust-analyzer, we should just write out the placeholder for now.