-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tracing-tree for logging / clean up debug output #544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be merged with a rebase @nathanwhit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah, stuff like debug!(?foo)
is surprising to me. Where can I read up on that?
That said, 👍 to merging, I trust this makes sense even if I don't get it yet |
It definitely does take a bit of getting used to, the tracing docs are quite helpful in explaining it. The macro syntax specifically is covered here. (As a side note, I've been meaning to add some documentation in the |
This PR makes it so we use the
tracing-tree
crate for logging output. This adds indentation to the logs, and generally makes the logging output much more readable compared to the current state.I also cleaned up many of the logging calls to properly use the
tracing
macros (e.g. create a new span when entering a function instead of just emitting an event).