Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recursive solver completeness example to correctly fail #528

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Fix recursive solver completeness example to correctly fail #528

merged 2 commits into from
Jun 16, 2020

Conversation

AzureMarker
Copy link
Member

@AzureMarker AzureMarker requested a review from nikomatsakis June 16, 2020 00:18
jackh726
jackh726 approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat extra, but can you actually add this as a test? Maybe just in misc?

@jackh726 jackh726 merged commit 75048f9 into rust-lang:master Jun 16, 2020
@AzureMarker AzureMarker deleted the fix/recursive-solver-completeness-example branch June 17, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 approved these changes

@nikomatsakis nikomatsakis Awaiting requested review from nikomatsakis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AzureMarker @jackh726