Support for ADTs #524
Merged
Support for ADTs #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
reviewed
Jun 14, 2020
nathanwhit
reviewed
Jun 14, 2020
nathanwhit
reviewed
Jun 14, 2020
nikomatsakis
approved these changes
Jun 15, 2020
|
Rebased - I'm just working on the final tests now |
|
So, we previously talked about merging last week. I went ahead and rebased and added the tests and updated for the new display tests. So, I'm gonna go ahead and merge this. Thanks @doctorn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is far from complete (I have practically no tests right now and I haven't really attempted any of the refactoring suggested in #506) however I thought this would be a good point to get some eyes on this as it doesn't break any tests... Any thoughts?
Will eventually resolve #505