Add FnOnce trait, and provide impl for Function type #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaron1011
force-pushed
the
feature/fn-once
branch
from
70dd385 to
91653d0
Compare
|
Btw I do have this and the output type implemented locally. But it's based on my closures branch, so I would have to split it out. |
Aaron1011
force-pushed
the
feature/fn-once
branch
2 times, most recently
from
fa10f9b to
8ba097c
Compare
Works towards rust-lang#363 I've followed the approach taken by rustc, where `FnOnce` has single generic argument: the tupled function parameters (e.g. `fn(u8, bool): FnOnce<(u8, bool)>`). I also extended the grammar to allow functions to take more than one argument. I've left `Fn` and `FnMut` for a separate PR - without a representation of closures in Chalk, they are not very useful.
Aaron1011
force-pushed
the
feature/fn-once
branch
from
bf38c30 to
dbdcbdd
Compare
|
@jackh726: I've added |
jackh726
requested changes
Jun 7, 2020
jackh726
requested changes
Jun 8, 2020
There was a problem hiding this comment.
Couple small things. And I want @nikomatsakis to take a quick look. But looks pretty good to me.
jackh726
approved these changes
Jun 8, 2020
nikomatsakis
requested changes
Jun 8, 2020
|
@nikomatsakis: I've added a |
nikomatsakis
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards #363
I've followed the approach taken by rustc, where
FnOncehas singlegeneric argument: the tupled function parameters
(e.g.
fn(u8, bool): FnOnce<(u8, bool)>).I also extended the grammar to allow functions to take more than one
argument.