Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make chalk-engine depend on chalk-ir #472

Merged
merged 8 commits into from
May 26, 2020
Merged

Make chalk-engine depend on chalk-ir #472

merged 8 commits into from
May 26, 2020

Conversation

jackh726
Copy link
Member

This actually cleans things up a lot.

There might be other things that can be cleaned up (for example, here I removed HhGoal since it basically mirrors GoalData.

c.c. @Mcat12 @nikomatsakis

AzureMarker
AzureMarker approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@AzureMarker AzureMarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward simplification, though of course I don't understand all of what's going on in the SLG code 🙂

nikomatsakis
nikomatsakis requested changes May 26, 2020
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but generally looks good

chalk-engine/src/boring_impls.rs Outdated Show resolved Hide resolved
@jackh726
Copy link
Member Author

@nikomatsakis addressed your comment

@nikomatsakis nikomatsakis merged commit d414743 into rust-lang:master May 26, 2020
@jackh726 jackh726 deleted the crate branch May 26, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit left review comments

@AzureMarker AzureMarker AzureMarker approved these changes

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackh726 @nikomatsakis @AzureMarker @nathanwhit